Fixing CLI usage not having enough rights in GLPI's profile system#22996
Open
C-Duv wants to merge 1 commit intoglpi-project:11.0/bugfixesfrom
Open
Fixing CLI usage not having enough rights in GLPI's profile system#22996C-Duv wants to merge 1 commit intoglpi-project:11.0/bugfixesfrom
C-Duv wants to merge 1 commit intoglpi-project:11.0/bugfixesfrom
Conversation
Contributor
|
This breaks tests |
cedric-anne
requested changes
Feb 4, 2026
Member
cedric-anne
left a comment
cedric-anne
left a comment
There was a problem hiding this comment.
IMHO, it is preferable to combine the usage of Session::callAsSystem() in the command with a Session::isRightChecksDisabled() check in the Profile::currentUserHaveMoreRightThan() method.
C-Duv
force-pushed
the
fix/gh22931-cli_commands_not_having_enough_rights
branch
from
c897d76 to
a748323
Compare
Contributor
Author
@cedric-anne Something like that? src/Glpi/Console/User/ResetPasswordCommand.php | 3 +--
src/Profile.php | 5 ++++-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/Glpi/Console/User/ResetPasswordCommand.php b/src/Glpi/Console/User/ResetPasswordCommand.php
index 05d211fd55..e234f5f172 100644
--- a/src/Glpi/Console/User/ResetPasswordCommand.php
+++ b/src/Glpi/Console/User/ResetPasswordCommand.php
@@ -76,8 +76,7 @@ class ResetPasswordCommand extends AbstractUserCommand
$user_input['password'] = $password;
$user_input['password2'] = $password;
-
- if ($user->update($user_input)) {
+ if (Session::callAsSystem(fn() => $user->update($user_input))) {
$output->writeln('<info>' . __('Reset password successful.') . '</info>');
return 0;
} else {
diff --git a/src/Profile.php b/src/Profile.php
index 047eed3522..cfbec75846 100644
--- a/src/Profile.php
+++ b/src/Profile.php
@@ -743,7 +743,10 @@ class Profile extends CommonDBTM implements LinkableToTilesInterface
{
global $DB;
- if (Session::isCron()) {
+ if (
+ Session::isRightChecksDisabled()
+ || Session::isCron()
+ ) {
return true;
}
if (count($IDs) === 0) { |
cedric-anne
approved these changes
Feb 4, 2026
cedric-anne
requested changes
Feb 4, 2026
Member
cedric-anne
left a comment
cedric-anne
left a comment
There was a problem hiding this comment.
Could you please validate it works as expected? According to the lint test failure, you did not test it, or you would have detect the failure.
|
|
||
|
|
||
| if ($user->update($user_input)) { | ||
| if (Session::callAsSystem(fn() => $user->update($user_input))) { |
Member
There was a problem hiding this comment.
Suggested change
| if (Session::callAsSystem(fn() => $user->update($user_input))) { | |
| if (\Session::callAsSystem(fn() => $user->update($user_input))) { |
Contributor
Author
There was a problem hiding this comment.
Fix applied, it made vendor/bin/phpstan analyze happy.
(and the code still fixes #22931)
The CLI/console `user:reset_password` was failing to reset an user's password with: > An error occurred during password update > Unable to reset password, please contact your administrator It's caused by `User::currentUserHaveMoreRightThan()` and/or `Profile::currentUserHaveMoreRightThan()` not detecting the CLI context of execution. This commit makes sure `User::update()` is executed as the system to bypass permissions enforcement and checks for such bypass in `Profile::currentUserHaveMoreRightThan()`. Issue: glpi-project#22931
C-Duv
force-pushed
the
fix/gh22931-cli_commands_not_having_enough_rights
branch
from
a748323 to
4fbd83d
Compare
trasher
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Adds a check for CLI execution in
Profile::currentUserHaveMoreRightThan()so it can grants it rights if needed.